bug/#3251_linkStyle-can't-specify-ids Fixed #4934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #4934 +/- ##
===========================================
- Coverage 79.97% 79.97% -0.01%
===========================================
Files 164 164
Lines 13623 13625 +2
Branches 693 693
===========================================
+ Hits 10895 10896 +1
- Misses 2579 2580 +1
Partials 149 149
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Hi @Yash-Singh1 , Could you please check my approach to fix this bug. Pardon for mistakes if any . Grateful for Your Suggestion. |
Yash-Singh1
approved these changes
Oct 10, 2023
packages/mermaid/src/diagrams/flowchart/parser/flow-style.spec.js
Outdated
Show resolved
Hide resolved
sidharthv96
requested changes
Oct 11, 2023
packages/mermaid/src/diagrams/flowchart/parser/flow-style.spec.js
Outdated
Show resolved
Hide resolved
nirname
approved these changes
Oct 22, 2023
Merged
via the queue into
mermaid-js:develop
with commit Nov 14, 2023
0c0f7a7
15 of 16 checks passed
|
@RounakJoshi09, Thank you for the contribution! |
aloisklink
added
Type: Bug / Error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Summary
In my fix, I've added a condition to handle the case where the index provided in linkStyle is greater than or equal to the length of the edges array. This provides a clear error message to the user and prevents a TypeError from occurring.
Resolves #3251
📏 Design Decisions
The implementation ensures that if the user attempts to apply a style to an index that exceeds the number of available edges, an error message will be displayed.
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSIONis used for all new features.developbranch