Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update classDiagram.md #4973

Merged
merged 3 commits into from
Nov 9, 2023
Merged

Conversation

SahilNagpure07
Copy link
Contributor

📑 Summary

Brief description about the content of your PR.

Fixed typo.

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

@netlify
Copy link

netlify bot commented Oct 22, 2023

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 36a727d
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/653a03da8b8f720008c39429
😎 Deploy Preview https://deploy-preview-4973--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Oct 22, 2023

Codecov Report

Merging #4973 (36a727d) into develop (5f117fc) will decrease coverage by 0.45%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4973      +/-   ##
===========================================
- Coverage    80.17%   79.72%   -0.45%     
===========================================
  Files          164      164              
  Lines        13820    13820              
  Branches       693      693              
===========================================
- Hits         11080    11018      -62     
- Misses        2591     2653      +62     
  Partials       149      149              
Flag Coverage Δ
e2e 85.67% <ø> (-0.56%) ⬇️
unit 42.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

@SahilNagpure07
Copy link
Contributor Author

@sidharthv96 please review

@sidharthv96 sidharthv96 merged commit 79bae62 into mermaid-js:develop Nov 9, 2023
16 of 17 checks passed
Copy link

mermaid-bot bot commented Nov 9, 2023

@SahilNagpure07, Thank you for the contribution!
You are now eligible for a year of Premium account on MermaidChart.
Sign up with your GitHub account to activate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants