fix(flow): fix invalid ellipseText regex #5016
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Summary
Fixes an invalid regex that was causing flowcharts to freeze if there was an ellipse node that had a
(
character in the text.E.g.
Resolves #4964
📏 Design Decisions
I'm not 100% sure why this was causing a freeze (shouldn't JISON throw an error instead?), but this seems to fix the issue, so 🤷.
As a side-note, if this test freezes, it completely locks up Vitest (setting a
timeout
parameter doesn't seem to help). We could instead run this test in achild_process
, but since creating a child process is pretty slow normally, so it's probably not worth slowing down our unit tests for it.📋 Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.develop
branch