Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs to properly showcase participant ordering #5306

Merged
merged 1 commit into from
Mar 23, 2024

Conversation

loucadufault
Copy link
Contributor

📑 Summary

Brief description about the content of your PR.

The example in the docs behaves the same with or without specifying the participants. The messages in the example have thus been reordered to make the explicit ordering useful, to better showcase the intent.

📏 Design Decisions

📋 Tasks

Make sure you

Copy link

netlify bot commented Feb 21, 2024

Deploy Preview for mermaid-js failed.

Name Link
🔨 Latest commit 392ebd0
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/65d68b949b98250008a17ffa

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (70c8a3d) 79.15% compared to head (392ebd0) 79.15%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5306   +/-   ##
========================================
  Coverage    79.15%   79.15%           
========================================
  Files          175      175           
  Lines        14514    14514           
  Branches       866      866           
========================================
  Hits         11488    11488           
  Misses        2823     2823           
  Partials       203      203           
Flag Coverage Δ
e2e 84.72% <ø> (ø)
unit 43.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@sidharthv96 sidharthv96 merged commit 97578c2 into mermaid-js:develop Mar 23, 2024
15 of 20 checks passed
Copy link

mermaid-bot bot commented Mar 23, 2024

@loucadufault, Thank you for the contribution!
You are now eligible for a year of Premium account on MermaidChart.
Sign up with your GitHub account to activate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants