[XYChart] fixed incorrect spacing between data points #5556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Type: Bug / Error
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5556 +/- ##
=======================================
Coverage 5.73% 5.73%
=======================================
Files 278 278
Lines 42019 42019
Branches 516 516
=======================================
Hits 2409 2409
Misses 39610 39610
Flags with carried forward coverage won't be shown. Click here to find out more.
|
OG-NI
changed the title
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
|
@OG-NI, Thank you for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Summary
This fixes the issue of XYCharts, where the spacing between the data points is sometimes incorrect and some data points not being displayed.
Resolves #5555
📏 Design Decisions
The formula calculating the distance between two data points when using a numeric range on the x-axis has been changed from
const step = (max - min + 1) / data.length;toconst step = (max - min) / (data.length - 1);. This maps the first value to the minimum on the x-axis, the last value to the maximum and evenly distributes all other values between the two ends.The changes made do not affect the way any existing demo chart is being rendered.
Feel free to ask if any additional documentation is needed.
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSIONis used for all new features.developbranch