Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Cleanup layoutelk #5730

Merged
merged 15 commits into from
Aug 21, 2024
Merged

chore: Cleanup layoutelk #5730

merged 15 commits into from
Aug 21, 2024

Conversation

sidharthv96
Copy link
Member

@sidharthv96 sidharthv96 commented Aug 21, 2024

📑 Summary

Fixes most of the type issues, the types are currently inferred automatically, should fix them later.

Resolves #

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 941 lines in your changes missing coverage. Please review.

Please upload report for BASE (develop@f4097df). Learn more about missing BASE report.
Report is 16 commits behind head on develop.

Files Patch % Lines
packages/mermaid-layout-elk/src/render.ts 0.00% 831 Missing ⚠️
...aid/src/rendering-util/rendering-elements/edges.js 0.00% 21 Missing ⚠️
packages/mermaid/src/rendering-util/render.ts 0.00% 19 Missing ⚠️
packages/mermaid/src/mermaid.ts 0.00% 18 Missing ⚠️
packages/mermaid/src/diagrams/xychart/xychartDb.ts 0.00% 8 Missing ⚠️
...kages/mermaid/src/diagrams/common/svgDrawCommon.ts 0.00% 7 Missing ⚠️
.../src/diagrams/xychart/chartBuilder/orchestrator.ts 0.00% 7 Missing ⚠️
packages/mermaid/src/diagrams/pie/pieRenderer.ts 0.00% 6 Missing ⚠️
packages/mermaid/src/rendering-util/createText.ts 0.00% 5 Missing ⚠️
packages/mermaid/src/diagrams/info/infoRenderer.ts 0.00% 3 Missing ⚠️
... and 7 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             develop   #5730   +/-   ##
=========================================
  Coverage           ?   5.32%           
=========================================
  Files              ?     317           
  Lines              ?   45097           
  Branches           ?     531           
=========================================
  Hits               ?    2402           
  Misses             ?   42695           
  Partials           ?       0           
Flag Coverage Δ
unit 5.32% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ckages/mermaid/src/diagrams/error/errorRenderer.ts 0.00% <0.00%> (ø)
packages/mermaid/src/diagrams/packet/renderer.ts 0.00% <0.00%> (ø)
...rams/xychart/chartBuilder/components/axis/index.ts 0.00% <0.00%> (ø)
...mermaid/src/diagrams/xychart/chartBuilder/index.ts 0.00% <0.00%> (ø)
packages/mermaid/src/internals.ts 0.00% <0.00%> (ø)
packages/mermaid/src/diagrams/info/infoRenderer.ts 0.00% <0.00%> (ø)
...rams/xychart/chartBuilder/components/chartTitle.ts 0.00% <0.00%> (ø)
...ms/xychart/chartBuilder/textDimensionCalculator.ts 0.00% <0.00%> (ø)
packages/mermaid/src/rendering-util/createText.ts 0.00% <0.00%> (ø)
packages/mermaid/src/diagrams/pie/pieRenderer.ts 0.00% <0.00%> (ø)
... and 7 more

Copy link

argos-ci bot commented Aug 21, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ⚠️ Changes detected (Review) 46 changed Aug 21, 2024, 2:33 PM

* elk-migration:
  chore: Update pnpm and lockfile
Base automatically changed from elk-migration to develop August 21, 2024 11:10
Copy link

netlify bot commented Aug 21, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 9134e1c
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/66c5f5d07a157b0008a22964
😎 Deploy Preview https://deploy-preview-5730--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sidharthv96 sidharthv96 marked this pull request as ready for review August 21, 2024 12:23
@knsv knsv enabled auto-merge August 21, 2024 14:20
@knsv knsv disabled auto-merge August 21, 2024 14:24
@knsv knsv merged commit 0b9554c into develop Aug 21, 2024
28 of 29 checks passed
@knsv knsv deleted the sidv/cleanupLayoutElk branch August 21, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants