Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add git to dev image for changeset #5834

Merged

Conversation

kairi003
Copy link
Contributor

@kairi003 kairi003 commented Sep 7, 2024

📑 Summary

This is a modification of the development environment, not the application or documentation.

With docker dev env, . /run pnpm changeset fails because there is no git command.

Resolves #5833

📏 Design Decisions

Add git command and set safe directory.

📋 Tasks

Copy link

changeset-bot bot commented Sep 7, 2024

⚠️ No Changeset found

Latest commit: 2879f37

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the Type: Bug / Error Something isn't working or is incorrect label Sep 7, 2024
Copy link

netlify bot commented Sep 7, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 2879f37
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/66dcbfcb7dc40b00083c000a
😎 Deploy Preview https://deploy-preview-5834--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Sep 7, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/mermaid-js/mermaid@5834
pnpm add https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@5834
pnpm add https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@5834
pnpm add https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@5834

commit: 2879f37

Copy link

codecov bot commented Sep 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 5.01%. Comparing base (58524ac) to head (2879f37).
Report is 10 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #5834      +/-   ##
==========================================
- Coverage     5.01%   5.01%   -0.01%     
==========================================
  Files          336     337       +1     
  Lines        48073   48084      +11     
  Branches       575     550      -25     
==========================================
  Hits          2413    2413              
- Misses       45660   45671      +11     
Flag Coverage Δ
unit 5.01% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@kairi003 kairi003 force-pushed the bug/5833_add_git_for_changeset branch from ff718ff to f957816 Compare September 7, 2024 17:55
Copy link

argos-ci bot commented Sep 7, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No changes detected - Sep 7, 2024, 9:22 PM

@kairi003 kairi003 force-pushed the bug/5833_add_git_for_changeset branch 2 times, most recently from 1ab5014 to de305dc Compare September 7, 2024 21:03
@kairi003 kairi003 force-pushed the bug/5833_add_git_for_changeset branch from de305dc to 2879f37 Compare September 7, 2024 21:04
@sidharthv96 sidharthv96 added this pull request to the merge queue Sep 8, 2024
Merged via the queue into mermaid-js:develop with commit c95a0c7 Sep 8, 2024
21 checks passed
Copy link

mermaid-bot bot commented Sep 8, 2024

@kairi003, Thank you for the contribution!
You are now eligible for a year of Premium account on MermaidChart.
Sign up with your GitHub account to activate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In Docker dev env, changeset requires git
2 participants