Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5787 Fix for issue with labels in firefox #5856

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

knsv
Copy link
Collaborator

@knsv knsv commented Sep 12, 2024

📑 Summary

Brief description about the content of your PR.

Resolves #5787

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Copy link

changeset-bot bot commented Sep 12, 2024

🦋 Changeset detected

Latest commit: bfd8c63

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
mermaid Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Sep 12, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit bfd8c63
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/66e2af5a70467c0008c86369
😎 Deploy Preview https://deploy-preview-5856--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Sep 12, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@5856
pnpm add https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@5856
pnpm add https://pkg.pr.new/mermaid-js/mermaid@5856
pnpm add https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@5856

commit: bfd8c63

Copy link
Collaborator

@ashishjain0512 ashishjain0512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the fix

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 5.00%. Comparing base (dd03043) to head (bfd8c63).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
packages/mermaid/src/rendering-util/createText.ts 0.00% 6 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #5856      +/-   ##
==========================================
- Coverage     5.00%   5.00%   -0.01%     
==========================================
  Files          338     338              
  Lines        48216   48221       +5     
  Branches       551     551              
==========================================
  Hits          2413    2413              
- Misses       45803   45808       +5     
Flag Coverage Δ
unit 5.00% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/mermaid/src/rendering-util/createText.ts 0.00% <0.00%> (ø)

Copy link

argos-ci bot commented Sep 12, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No changes detected - Sep 12, 2024, 9:13 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text is not rendered in nodes of flowchart with several commas
2 participants