Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Trying to add flowchart Langium parser #5892

Draft
wants to merge 14 commits into
base: develop
Choose a base branch
from

Conversation

stereobooster
Copy link

@stereobooster stereobooster commented Sep 24, 2024

📑 Summary

Trying to add flowchart Langium-based parser

Resolves #4401

📏 Design Decisions

Same approach as others Langium-based parser in this repo

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Copy link

changeset-bot bot commented Sep 24, 2024

⚠️ No Changeset found

Latest commit: f89db31

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Sep 24, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit f89db31
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/6737c5cb27c1760008dcfb9f
😎 Deploy Preview https://deploy-preview-5892--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Sep 24, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/mermaid-js/mermaid@5892
pnpm add https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@5892
pnpm add https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@5892
pnpm add https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@5892

commit: f89db31

Copy link

argos-ci bot commented Sep 24, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ⚠️ Changes detected (Review) 1 changed Nov 15, 2024, 10:14 PM

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 128 lines in your changes missing coverage. Please review.

Project coverage is 4.49%. Comparing base (8328f74) to head (f89db31).

Files with missing lines Patch % Lines
packages/parser/src/language/flowchart/module.ts 0.00% 54 Missing ⚠️
...es/parser/src/language/flowchart/valueConverter.ts 0.00% 51 Missing ⚠️
packages/parser/tests/test-util.ts 0.00% 16 Missing ⚠️
...ages/parser/src/language/flowchart/tokenBuilder.ts 0.00% 3 Missing ⚠️
packages/parser/src/language/index.ts 0.00% 3 Missing ⚠️
packages/parser/src/language/flowchart/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #5892      +/-   ##
==========================================
- Coverage     4.49%   4.49%   -0.01%     
==========================================
  Files          382     387       +5     
  Lines        53914   54051     +137     
  Branches       621     601      -20     
==========================================
+ Hits          2425    2428       +3     
- Misses       51489   51623     +134     
Flag Coverage Δ
unit 4.49% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/parser/src/language/flowchart/index.ts 0.00% <0.00%> (ø)
...ages/parser/src/language/flowchart/tokenBuilder.ts 0.00% <0.00%> (ø)
packages/parser/src/language/index.ts 0.00% <0.00%> (ø)
packages/parser/tests/test-util.ts 0.00% <0.00%> (ø)
...es/parser/src/language/flowchart/valueConverter.ts 0.00% <0.00%> (ø)
packages/parser/src/language/flowchart/module.ts 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

@stereobooster stereobooster force-pushed the flowchart-grammar branch 2 times, most recently from 94b0ae1 to f98affb Compare November 15, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(parser): reimplement parser in langium instead of jison
1 participant