Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v11.4.0 #6007

Merged
merged 201 commits into from
Oct 30, 2024
Merged

Release v11.4.0 #6007

merged 201 commits into from
Oct 30, 2024

Conversation

ashishjain0512
Copy link
Collaborator

📑 Summary

This pull request includes a variety of changes, including the addition of new features, bug fixes, and updates to dependencies and configurations. The most important changes include the introduction of a new Kanban board diagram type, updates to class diagrams, and several bug fixes. Additionally, there are updates to GitHub Actions workflows and various refactorings to improve code maintainability.

New Features and Diagram Updates:

  • Added Kanban board as a new diagram type (.build/jsonSchema.ts, .cspell/mermaid-terms.txt, .changeset/kind-drinks-invent.md). [1] [2] [3]
  • Updated class diagrams to a new unified rendering approach and added several new features and fixes (.changeset/polite-rules-rescue.md).

Bug Fixes:

  • Fixed jagged edge issue for icon shapes (.changeset/chilly-hotels-mix.md).
  • Fixed icon color issue for colored icons (.changeset/heavy-cats-mate.md).
  • Fixed error handling in mermaid.parse to match errors thrown by mermaid.render (.changeset/thick-elephants-search.md).

Refactoring and Code Improvements:

  • Introduced PackageOptions interface and refactored build configuration to use this new type (.build/common.ts, .esbuild/build.ts, .esbuild/server.ts, .esbuild/util.ts). [1] [2] [3] [4]

Updates to GitHub Actions:

  • Updated various GitHub Actions to newer versions (.github/workflows/autofix.yml, .github/workflows/build-docs.yml, .github/workflows/codeql.yml, .github/workflows/e2e-applitools.yml, .github/workflows/e2e.yml, .github/workflows/lint.yml, .github/workflows/publish-docs.yml). [1] [2] [3] [4] [5] [6] [7]
  • Added a new workflow for generating E2E timings (.github/workflows/e2e-timings.yml).

These changes collectively enhance the functionality, maintainability, and reliability of the project.

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

aloisklink and others added 23 commits October 29, 2024 21:14
Exclude the `node.shape` type from `kanbanItem()`, as otherwise it
causes a circular dependency in the types.
Add the appropriate type checks to ensure that we're only ever calling:

- `insertCluster()` with `ClusterNode`
- `insertNode()` with a `NonClusterNode`

Fixes: 7401cb8
This snapshot should have been modified in
c1ca351 (Fix (tmp) for handling of config of htmlLabels ion note. MOvint class box out of flowchart docs, 2024-10-30

Fixes: c1ca351
Copy link

changeset-bot bot commented Oct 30, 2024

🦋 Changeset detected

Latest commit: b022943

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
mermaid Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Oct 30, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit b022943
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/67223d1486f16100089c8d24
😎 Deploy Preview https://deploy-preview-6007--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 0.21810% with 6405 lines in your changes missing coverage. Please review.

Project coverage is 4.49%. Comparing base (ef8c002) to head (b022943).
Report is 474 commits behind head on master.

Files with missing lines Patch % Lines
...id/src/rendering-util/rendering-elements/shapes.ts 0.00% 504 Missing ⚠️
...c/rendering-util/rendering-elements/shapes/util.ts 0.00% 282 Missing ⚠️
packages/mermaid/src/diagrams/kanban/kanbanDb.ts 0.00% 253 Missing ⚠️
packages/mermaid/src/diagrams/class/classDb.ts 0.00% 238 Missing ⚠️
packages/mermaid/src/diagrams/class/shapeUtil.ts 0.00% 223 Missing ⚠️
...ndering-util/rendering-elements/shapes/classBox.ts 0.00% 207 Missing ⚠️
...ering-util/rendering-elements/shapes/kanbanItem.ts 0.00% 163 Missing ⚠️
...ring-util/rendering-elements/shapes/imageSquare.ts 0.00% 149 Missing ⚠️
...ring-util/rendering-elements/shapes/iconRounded.ts 0.00% 145 Missing ⚠️
...ering-util/rendering-elements/shapes/iconSquare.ts 0.00% 145 Missing ⚠️
... and 87 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6007      +/-   ##
=========================================
- Coverage    5.00%   4.49%   -0.51%     
=========================================
  Files         337     383      +46     
  Lines       48209   53925    +5716     
  Branches      576     596      +20     
=========================================
+ Hits         2413    2425      +12     
- Misses      45796   51500    +5704     
Flag Coverage Δ
unit 4.49% <0.21%> (-0.51%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/mermaid/src/defaultConfig.ts 45.38% <100.00%> (+0.81%) ⬆️
...ermaid/src/rendering-util/insertElementsForSize.js 0.00% <ø> (ø)
...aid/src/rendering-util/rendering-elements/edges.js 0.00% <ø> (ø)
packages/mermaid/src/utils/lineWithOffset.ts 0.00% <ø> (ø)
.build/jsonSchema.ts 0.00% <0.00%> (ø)
packages/mermaid/src/dagre-wrapper/index.js 0.00% <0.00%> (ø)
...ages/mermaid/src/diagrams/class/classDiagram-v2.ts 0.00% <0.00%> (ø)
...ackages/mermaid/src/diagrams/class/classDiagram.ts 0.00% <0.00%> (ø)
...rc/rendering-util/layout-algorithms/dagre/index.js 0.00% <0.00%> (ø)
...s/mermaid/src/diagram-api/diagram-orchestration.ts 0.00% <0.00%> (ø)
... and 91 more

... and 4 files with indirect coverage changes

@ashishjain0512 ashishjain0512 merged commit c6e1271 into master Oct 30, 2024
19 of 29 checks passed
@ashishjain0512 ashishjain0512 deleted the release/11.4.0 branch October 30, 2024 14:19
@github-actions github-actions bot mentioned this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.