-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Elk rendering of Diamond shape intersections #6081
Conversation
🦋 Changeset detectedLatest commit: 3753831 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
commit: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6081 +/- ##
=======================================
Coverage 4.49% 4.49%
=======================================
Files 383 382 -1
Lines 53925 53915 -10
Branches 596 621 +25
=======================================
Hits 2425 2425
+ Misses 51500 51490 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
|
📑 Summary
Elk rendering of Diamond shape can have incorrect intersection calculations
Resolves #6080
📏 Design Decisions
Handling of the intersection calculations but some things stand out. SImilar changes should be done for all shaoes wchich will lead to a bigger refactoring of how intersections are calculated, Also we should use enums for handling shape types.
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.