Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Elk rendering of Diamond shape intersections #6081

Merged
merged 4 commits into from
Nov 26, 2024
Merged

Conversation

knsv
Copy link
Collaborator

@knsv knsv commented Nov 25, 2024

📑 Summary

Elk rendering of Diamond shape can have incorrect intersection calculations

Resolves #6080

📏 Design Decisions

Handling of the intersection calculations but some things stand out. SImilar changes should be done for all shaoes wchich will lead to a bigger refactoring of how intersections are calculated, Also we should use enums for handling shape types.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Copy link

changeset-bot bot commented Nov 25, 2024

🦋 Changeset detected

Latest commit: 3753831

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@mermaid-js/layout-elk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 3753831
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/6744a2caaf090f0008eb940e
😎 Deploy Preview https://deploy-preview-6081--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Nov 25, 2024

Open in Stackblitz

npm i https://pkg.pr.new/mermaid-js/mermaid@6081
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@6081
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@6081
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@6081

commit: 3753831

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 4.49%. Comparing base (d3b2c7e) to head (3753831).
Report is 7 commits behind head on develop.

Files with missing lines Patch % Lines
packages/mermaid-layout-elk/src/render.ts 0.00% 15 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #6081   +/-   ##
=======================================
  Coverage     4.49%   4.49%           
=======================================
  Files          383     382    -1     
  Lines        53925   53915   -10     
  Branches       596     621   +25     
=======================================
  Hits          2425    2425           
+ Misses       51500   51490   -10     
Flag Coverage Δ
unit 4.49% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/mermaid-layout-elk/src/render.ts 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@ashishjain0512 ashishjain0512 merged commit cc29437 into develop Nov 26, 2024
19 of 24 checks passed
@ashishjain0512 ashishjain0512 deleted the 6080-fix branch November 26, 2024 09:52
@github-actions github-actions bot mentioned this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Elk rendering of Diamond shape can have incorrect intersection calculations
2 participants