Merge pull request #624 from meroxa/app-with-fn-env

Early failure for deploying an application with a function to an env

cmd/meroxa/root/apps/deploy.go

@@ -482,6 +482,12 @@ func (d *Deploy) getAppImage(ctx context.Context) (string, error) {
 		return "", nil
 	}
 
+	// Prevent creation of function in an Env
+	if d.flags.Environment != "" {
+		d.logger.StopSpinnerWithStatus("\t", log.Failed)
+		return "", errors.New("cannot deploy an application with a functions to an environment")
+	}
+
 	d.logger.StopSpinnerWithStatus("Application processes found. Creating application image...", log.Successful)
 
 	d.localDeploy.Lang = d.lang

cmd/meroxa/root/apps/deploy_test.go

@@ -848,6 +848,68 @@ func TestGetPlatformImage(t *testing.T) {
 	}
 }
 
+func TestGetAppImage(t *testing.T) {
+	ctx := context.Background()
+	ctrl := gomock.NewController(t)
+	logger := log.NewTestLogger()
+	appName := "my-app"
+
+	tests := []struct {
+		name           string
+		meroxaClient   func() meroxa.Client
+		mockTurbineCLI func() turbine.CLI
+		err            error
+	}{
+		{
+			name: "Don't build app image when for app with no function",
+			meroxaClient: func() meroxa.Client {
+				return mock.NewMockClient(ctrl)
+			},
+			mockTurbineCLI: func() turbine.CLI {
+				mockTurbineCLI := turbine_mock.NewMockCLI(ctrl)
+				mockTurbineCLI.EXPECT().
+					NeedsToBuild(ctx, appName).
+					Return(false, nil)
+				return mockTurbineCLI
+			},
+		},
+		{
+			name: "Fail to build app image when deploying to an environment",
+			meroxaClient: func() meroxa.Client {
+				return mock.NewMockClient(ctrl)
+			},
+			mockTurbineCLI: func() turbine.CLI {
+				mockTurbineCLI := turbine_mock.NewMockCLI(ctrl)
+				mockTurbineCLI.EXPECT().
+					NeedsToBuild(ctx, appName).
+					Return(true, nil)
+				return mockTurbineCLI
+			},
+			err: errors.New("cannot deploy an application with a functions to an environment"),
+		},
+	}
+
+	for _, tc := range tests {
+		t.Run(tc.name, func(t *testing.T) {
+			d := &Deploy{
+				client:     tc.meroxaClient(),
+				turbineCLI: tc.mockTurbineCLI(),
+				logger:     logger,
+				appName:    appName,
+			}
+			d.flags.Environment = "my-env"
+
+			_, err := d.getAppImage(ctx)
+			if err != nil {
+				require.NotNil(t, tc.err)
+				require.Equal(t, tc.err, err)
+			} else {
+				require.Empty(t, tc.err)
+			}
+		})
+	}
+}
+
 func TestPrepareAppName(t *testing.T) {
 	ctx := context.Background()
 	appName := "my-app"