Skip to content

Commit

Permalink
Enable visibility for environment flag on apps deploy
Browse files Browse the repository at this point in the history
  • Loading branch information
Diana Doherty committed Feb 8, 2023
1 parent 2a98f28 commit 9cf2ca1
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 2 deletions.
2 changes: 1 addition & 1 deletion cmd/meroxa/root/apps/deploy.go
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ type Deploy struct {
Path string `long:"path" usage:"Path to the app directory (default is local directory)"`
DockerHubUserName string `long:"docker-hub-username" usage:"DockerHub username to use to build and deploy the app" hidden:"true"` //nolint:lll
DockerHubAccessToken string `long:"docker-hub-access-token" usage:"DockerHub access token to use to build and deploy the app" hidden:"true"` //nolint:lll
Environment string `long:"env" usage:"environment (name or UUID) where application will be deployed to" hidden:"true"`
Environment string `long:"env" usage:"environment (name or UUID) where application will be deployed to"`
Spec string `long:"spec" usage:"Deployment specification version to use to build and deploy the app" hidden:"true"`
SkipCollectionValidation bool `long:"skip-collection-validation" usage:"Skips unique destination collection and looping validations"` //nolint:lll
Verbose bool `long:"verbose" usage:"Prints more logging messages" hidden:"true"`
Expand Down
2 changes: 1 addition & 1 deletion cmd/meroxa/root/apps/deploy_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ func TestDeployAppFlags(t *testing.T) {
{name: "spec", required: false, hidden: true},
{name: "skip-collection-validation", required: false, hidden: false},
{name: "verbose", required: false, hidden: true},
{name: "env", required: false, hidden: true},
{name: "env", required: false, hidden: false},
}

c := builder.BuildCobraCommand(&Deploy{})
Expand Down
1 change: 1 addition & 0 deletions docs/cmd/md/meroxa_apps_deploy.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ meroxa apps deploy --path ./my-app
### Options

```
--env string environment (name or UUID) where application will be deployed to
-h, --help help for deploy
--path string Path to the app directory (default is local directory)
--skip-collection-validation Skips unique destination collection and looping validations
Expand Down
1 change: 1 addition & 0 deletions docs/cmd/www/meroxa-apps-deploy.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ meroxa apps deploy --path ./my-app
### Options

```
--env string environment (name or UUID) where application will be deployed to
-h, --help help for deploy
--path string Path to the app directory (default is local directory)
--skip-collection-validation Skips unique destination collection and looping validations
Expand Down
2 changes: 2 additions & 0 deletions etc/completion/meroxa.completion.sh
Original file line number Diff line number Diff line change
Expand Up @@ -521,6 +521,8 @@ _meroxa_apps_deploy()
flags_with_completion=()
flags_completion=()

flags+=("--env=")
two_word_flags+=("--env")
flags+=("--help")
flags+=("-h")
flags+=("--path=")
Expand Down
4 changes: 4 additions & 0 deletions etc/man/man1/meroxa-apps-deploy.1
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ If deployment was successful, you should expect an application you'll be able to


.SH OPTIONS
.PP
\fB--env\fP=""
environment (name or UUID) where application will be deployed to

.PP
\fB-h\fP, \fB--help\fP[=false]
help for deploy
Expand Down

0 comments on commit 9cf2ca1

Please sign in to comment.