Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(list): Show pipeline id when listing connectors #103

Merged
merged 3 commits into from
Apr 5, 2021

Conversation

raulb
Copy link
Member

@raulb raulb commented Mar 31, 2021

Description of change

In order to be able to indicate the association of a connector of a pipeline, it's important we start showing this information when listing connectors. This pull-request does that.

Fixes https://meroxa.atlassian.net/browse/PLATFORM-370

⚠️ It requires changes in meroxa-go which are currently vendored here.

Once this other pull-request is merged into master, we should update its version here.

Type of change

  • New feature
  • Bug fix
  • Refactor
  • Documentation

Demo

❯ .m list connectors
 ID        NAME          TYPE                   STREAMS                STATE    PIPELINE
===== ============== ============= ================================= ========= ==========
 255   my-connector   jdbc-source   output:                           running   11
                                    resource-149-499379-public.User
❯ .m list connectors --json
[
  {
    "id": 255,
    "type": "jdbc-source",
    "name": "my-connector",
    "config": {},
    "metadata": {
      "mx:connectorType": "source"
    },
    "streams": {
      "dynamic": false,
      "output": [
        "resource-149-499379-public.User"
      ]
    },
    "state": "running",
    "pipeline_id": 11
  }
]

@raulb raulb requested a review from lovromazgon March 31, 2021 21:18
@raulb raulb self-assigned this Mar 31, 2021
@raulb raulb merged commit 6db183e into master Apr 5, 2021
@raulb raulb deleted the pipeline-connectors branch April 5, 2021 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants