Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLATFORM-429] feat(create:endpoint): Adds feedback #117

Merged
merged 1 commit into from
Apr 13, 2021
Merged

[PLATFORM-429] feat(create:endpoint): Adds feedback #117

merged 1 commit into from
Apr 13, 2021

Conversation

raulb
Copy link
Member

@raulb raulb commented Apr 12, 2021 •
edited
Loading

Description of change

It also refactors this command adding tests.

Fixes https://meroxa.atlassian.net/browse/PLATFORM-429

Type of change

  • New feature
  • Bug fix
  • Refactor
  • Documentation

How was this tested?

  • Unit Tests
  • Tested in staging

Demo

Before this pull-request

$ meroxa create endpoint to-mongo-api --protocol http --stream my-stream

After this pull-request

$ meroxa create endpoint to-mongo-api --protocol http --stream my-stream
Creating endpoint...
Endpoint successfully created!

feat(create:endpoint): Adds feedback
8e0d766 
It also refactors command.
@raulb raulb self-assigned this Apr 12, 2021
@raulb raulb requested a review from ahmeroxa April 12, 2021 20:45
jayjayjpg
jayjayjpg approved these changes Apr 13, 2021
View reviewed changes
Copy link
Contributor

@jayjayjpg jayjayjpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

cmd/create.go Show resolved Hide resolved
@raulb raulb merged commit bf757a4 into master Apr 13, 2021
@raulb raulb deleted the raulb/feedback-create-endpoint branch April 13, 2021 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayjayjpg jayjayjpg jayjayjpg approved these changes

@anaptfox anaptfox Awaiting requested review from anaptfox

@lovromazgon lovromazgon Awaiting requested review from lovromazgon

@ahmeroxa ahmeroxa Awaiting requested review from ahmeroxa

Assignees

@raulb raulb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raulb @jayjayjpg