Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve vendoring of meroxa/meroxa-go #34

Merged
merged 1 commit into from
Oct 19, 2020
Merged

Improve vendoring of meroxa/meroxa-go #34

merged 1 commit into from
Oct 19, 2020

Conversation

owenthereal
Copy link
Contributor

Description of change

  • Vendor private repos by setting GOPRIVATE
  • Add make tasks
  • Update documentation

Type of change

  • New feature
  • Bug fix
  • Refactor
  • Documentation

How was this tested?

  • Manual
  • Unit Tests
  • Deployed to staging

* Vendor private repos by setting `GOPRIVATE`
* Add make tasks
* Update documentation
Copy link
Member

@ahmeroxa ahmeroxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@owenthereal owenthereal merged commit fc1b30c into master Oct 19, 2020
@owenthereal owenthereal deleted the go_tidy branch October 19, 2020 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants