Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI improvement to facilitate acceptance tests #35

Merged
merged 3 commits into from
Nov 4, 2020
Merged

CLI improvement to facilitate acceptance tests #35

merged 3 commits into from
Nov 4, 2020

Conversation

owenthereal
Copy link
Contributor

Description of change

A bunch of CLI improvement to facilitate acceptance tests:

  • Allow passing in username, password, and email for signup and login (this makes automation easier)
  • Output only JSON when --json flag is provided (this makes machine parsing easier)
  • Some util make tasks

Type of change

  • New feature
  • Bug fix
  • Refactor
  • Documentation

How was this tested?

  • Unit Tests
  • Deployed to staging

Additional references

Ref: https://github.com/meroxa/infra/pull/25

@owenthereal
Make CLI automatable in acceptance tests
f0ddb18 
* Allow username & password to be passed in
* Output JSON to be parsed by machine
@owenthereal
Make task to install into GOPATH
20fda71
@ahmeroxa
Copy link
Member

ahmeroxa commented Nov 2, 2020

We should update the list commands to use the persistent json flag instead of its own output option

@owenthereal
Copy link
Contributor Author

@ahmeroxa 👍 I added --json to other commands, include list *

ahmeroxa
ahmeroxa approved these changes Nov 4, 2020
View reviewed changes
Copy link
Member

@ahmeroxa ahmeroxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@owenthereal owenthereal merged commit 506e071 into master Nov 4, 2020
@owenthereal owenthereal deleted the acceptance_test branch November 4, 2020 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmeroxa ahmeroxa ahmeroxa approved these changes

@terrancej terrancej Awaiting requested review from terrancej

@mwoods79 mwoods79 Awaiting requested review from mwoods79

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@owenthereal @ahmeroxa