Fix linting errors based on golint #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmeroxa
reviewed
Jan 29, 2021
ahmeroxa
reviewed
Jan 29, 2021
owenthereal
approved these changes
Jan 29, 2021
|
Enabling Fixing them all now would take a considerable amount of time, and I'm prioritising other things such as tests and new features part of our MVP so I'm calling this PR done. Once those exceptions are fixed (or softened) we could enable a GitHub action to make sure there are no regressions. Shipping this PR for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Starting to work on this project, I noticed linting errors thrown by
golint. This PR fixes them all.It also adds
CODEOWNERS.Type of change
How was this tested?