Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(add): Use add instead of create for resources #41

Merged
merged 8 commits into from
Feb 3, 2021

Conversation

raulb
Copy link
Member

@raulb raulb commented Feb 1, 2021

Description of change

A brief description of the change, what it is and why it was made.

Fixes:

Type of change

  • New feature
  • Bug fix
  • Refactor
  • Documentation

Documentation updated

How was this tested?

  • Unit Tests
  • Deployed to staging

Additional references

How it looks now

❯ .m help
The Meroxa CLI allows quick and easy access to the Meroxa data platform.

Using the CLI you are able to create and manage sophisticated data pipelines
with only a few simple commands. You can get started by listing the supported
resource types:

meroxa list resource-types

Usage:
  meroxa [command]

Available Commands:
  add         add a meroxa resource
  completion  Generate completion script
  connect     connect two resources together
  create      create meroxa pipeline components
  describe    describe a component
  destroy     destroy a component
  help        Help about any command
  list        list components
  login       log into the Meroxa platform
  logout      logout of the Meroxa platform
  signup      sign up to the Meroxa platform
  version     display the version of the Meroxa CLI

Flags:
  -h, --help   help for meroxa
      --json   output json


❯ .m add resource
Error: requires at least 1 arg(s), only received 0
Usage:
  meroxa add resource <resource-type> [flags]

Flags:
      --credentials string   resource credentials
  -h, --help                 help for resource
  -m, --metadata string      resource metadata
  -n, --name string          resource name (default "foo")
  -u, --url string           resource url

Global Flags:
      --json   output json

requires at least 1 arg(s), only received 0

@raulb raulb self-assigned this Feb 1, 2021
@raulb raulb force-pushed the raul/update-add-resource-command branch from 0fae2b0 to 65e1404 Compare February 2, 2021 11:58
@raulb raulb marked this pull request as ready for review February 2, 2021 15:02
@raulb
Copy link
Member Author

raulb commented Feb 2, 2021

Calling this one ready for review. I gave adding tests a try, but I'm struggling to approach this in a way that doesn't become too cumbersome. I'll keep thinking about this. In the meantime, this should be good to go.

@raulb raulb requested a review from ahmeroxa February 2, 2021 15:10
cmd/add.go Outdated Show resolved Hide resolved
cmd/add.go Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
cmd/add.go Outdated Show resolved Hide resolved
cmd/add.go Outdated Show resolved Hide resolved
cmd/add.go Outdated Show resolved Hide resolved
@raulb raulb force-pushed the raul/update-add-resource-command branch from 65e1404 to 75d3a19 Compare February 2, 2021 21:16
@raulb
Copy link
Member Author

raulb commented Feb 2, 2021

Per CI, Looks like I didn't quite did the refactor well. I'll look into this.

@raulb raulb force-pushed the raul/update-add-resource-command branch 2 times, most recently from 235623b to fb304f5 Compare February 2, 2021 21:43
@raulb raulb requested a review from ahmeroxa February 2, 2021 21:45
cmd/add.go Outdated Show resolved Hide resolved
Copy link
Member

@ahmeroxa ahmeroxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 non-blocking comment. Looks good otherwise 👍

Copy link
Contributor

@owenthereal owenthereal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more feedback. After that it can be merged.

cmd/add.go Outdated Show resolved Hide resolved
@raulb raulb force-pushed the raul/update-add-resource-command branch from fb304f5 to 37fec8f Compare February 3, 2021 14:15
@raulb raulb merged commit 193b55f into master Feb 3, 2021
@raulb raulb deleted the raul/update-add-resource-command branch February 3, 2021 14:49
@raulb
Copy link
Member Author

raulb commented Feb 3, 2021

Submitted a suggestion to edit the docs once we release these changes to customers: https://dash.readme.com/project/meroxa/v1.0/suggested/update/601abd5eb7b444004beb30c0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants