-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(add): Use add instead of create for resources #41
Conversation
0fae2b0
to
65e1404
Compare
Calling this one ready for review. I gave adding tests a try, but I'm struggling to approach this in a way that doesn't become too cumbersome. I'll keep thinking about this. In the meantime, this should be good to go. |
65e1404
to
75d3a19
Compare
Per CI, Looks like I didn't quite did the refactor well. I'll look into this. |
235623b
to
fb304f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 non-blocking comment. Looks good otherwise 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more feedback. After that it can be merged.
fb304f5
to
37fec8f
Compare
Submitted a suggestion to edit the docs once we release these changes to customers: https://dash.readme.com/project/meroxa/v1.0/suggested/update/601abd5eb7b444004beb30c0 |
Description of change
A brief description of the change, what it is and why it was made.
Fixes:
Type of change
Documentation updated
How was this tested?
Additional references
How it looks now