Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): Do not show headers when listing empty lists #53

Merged
merged 3 commits into from
Feb 11, 2021

Conversation

raulb
Copy link
Member

@raulb raulb commented Feb 10, 2021

Description of change

I noticed that when listing resources, pipelines, etc... even though the output is empty, we still show the header.

Before:

❯ .m list resources
 ID   TYPE   NAME   URL
==== ====== ====== =====

Now:

❯ .m list resources

Fixes PLATFORM-68

Type of change

  • New feature
  • Bug fix
  • Refactor
  • Documentation

How was this tested?

  • Unit Tests
  • Deployed to staging

@raulb raulb self-assigned this Feb 10, 2021
@mwoods79
Copy link
Contributor

@raulb shouldn't we show the user something though? Like "no results", just some type of feedback?

@raulb
Copy link
Member Author

raulb commented Feb 11, 2021

@mwoods79 I was trying to follow the same pattern we had in Heroku when listing items and they didn't return any result:

❯ heroku teams

I personally think the feedback of showing an empty line could be a good start without getting into the weeds of what the right message is. What do you think?

Copy link
Contributor

@mwoods79 mwoods79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@raulb raulb merged commit dcfddda into master Feb 11, 2021
@raulb raulb deleted the raul/fix-output-empty-lists branch February 11, 2021 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants