Turbine-Ruby CLI Stub #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmd/meroxa/turbine/ruby/run.go
Outdated
|
|
||
| func (t *turbineRbCLI) Run(ctx context.Context) (err error) { | ||
| // Run turbine-core gRPC server | ||
| return err |
There was a problem hiding this comment.
this will return nil, so I recommend adding an error
cmd/meroxa/turbine/ruby/build.go
Outdated
| ) | ||
|
|
||
| func (t *turbineRbCLI) Build(ctx context.Context, appName string, platform bool) (string, error) { | ||
| return "", nil |
There was a problem hiding this comment.
I think these should return a "not implemented" error
anna-cross
force-pushed
the
rb_cli_stub
branch
from
b701b00
to
8317cfb
Compare
dianadoherty
approved these changes
Nov 10, 2022
raulb
approved these changes
Nov 11, 2022
There was a problem hiding this comment.
@dianadoherty do you think we should a feature flag for the ruby path until we finish it?
because turbine ruby commands are not exposed in this PR, this PR can be merged. But we should definitely add a flag for any future pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Stubs for turbine-ruby cli. Contains functions needed by interfaces
cli/cmd/meroxa/turbine/interface.go
Line 7 in a3f4517
Fixes #521
Type of change
How was this tested?