Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ruby turbine command test #551

Merged
merged 1 commit into from
Nov 17, 2022
Merged

add ruby turbine command test #551

merged 1 commit into from
Nov 17, 2022

Conversation

lyuboxa
Copy link
Contributor

@lyuboxa lyuboxa commented Nov 17, 2022 •
edited
Loading

Description of change

This is a clean up to add better test for the executing command.

Type of change

  • New feature
  • Bug fix
  • Refactor
  • Documentation

How was this tested?

  • Unit Tests
  • Tested in staging
  • Tested in minikube

Demo

before after

Additional references

Documentation updated

@lyuboxa lyuboxa self-assigned this Nov 17, 2022
raulb
raulb approved these changes Nov 17, 2022
View reviewed changes
Copy link
Member

@raulb raulb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. ⚠️ Haven't tested it locally

@lyuboxa lyuboxa merged commit 00ac7d5 into master Nov 17, 2022
@lyuboxa lyuboxa deleted the lk/fix-test branch November 17, 2022 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulb raulb raulb approved these changes

Assignees

@lyuboxa lyuboxa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lyuboxa @raulb