Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flapping test and rename TurbineRb #553

Merged
merged 2 commits into from
Nov 17, 2022
Merged

Fix flapping test and rename TurbineRb #553

merged 2 commits into from
Nov 17, 2022

Conversation

lyuboxa
Copy link
Contributor

@lyuboxa lyuboxa commented Nov 17, 2022 •
edited
Loading

Description of change

Fixes flapping test in apps run for ruby and renames Turbine to TurbineRb

Type of change

  • New feature
  • Bug fix
  • Refactor
  • Documentation

How was this tested?

  • Unit Tests
  • Tested in staging
  • Tested in minikube

Demo

before after

Additional references

Documentation updated

@lyuboxa lyuboxa self-assigned this Nov 17, 2022
janelletavares
janelletavares approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@janelletavares janelletavares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me. don't forget the lint nits

@lyuboxa lyuboxa merged commit b525f4e into master Nov 17, 2022
@lyuboxa lyuboxa deleted the lk/fix-flapping-test branch November 17, 2022 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dianadoherty dianadoherty dianadoherty approved these changes

@janelletavares janelletavares janelletavares approved these changes

Assignees

@lyuboxa lyuboxa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lyuboxa @janelletavares @dianadoherty