Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli): Change CLI output to include arch #56

Merged
merged 1 commit into from
Feb 17, 2021

Conversation

raulb
Copy link
Member

@raulb raulb commented Feb 15, 2021

Description of change

Fixes PLATFORM-76

Change output when doing CLI version:

Before:

❯ .m version
Meroxa CLI version 0.1.14

Now:

❯ .m version
meroxa/0.1.14 darwin/amd64

Type of change

  • New feature
  • Bug fix
  • Refactor
  • Documentation

How was this tested?

  • Unit Tests
  • Deployed to staging

Additional references

This is an iteration over #33 which was taking advantage of the ldflags flags.

Once we open source this repository and we make the formula available via brew install, we should update the release workflow to make sure we bump its formula version: https://github.com/mislav/bump-homebrew-formula-action.

Fixes [PLATFORM-76](https://meroxa.atlassian.net/browse/PLATFORM-76)

Change output when doing CLI version:

Before:

```
❯ .m version
Meroxa CLI version 0.1.14
```

Now:

```
❯ .m version
meroxa/0.1.14 darwin/amd64
```
@raulb raulb self-assigned this Feb 15, 2021
Copy link
Member

@ahmeroxa ahmeroxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@raulb raulb merged commit 6719dfd into master Feb 17, 2021
@raulb raulb deleted the raul/changes-on-meroxa-version branch February 17, 2021 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants