Update ruby list resource #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anna-cross
force-pushed
the
ruby_list_resources
branch
2 times, most recently
from
681baba
to
bef0eda
Compare
dianadoherty
reviewed
Dec 2, 2022
cmd/meroxa/turbine/ruby/deploy.go
Outdated
Comment on lines
95
to
96
| for _, r := range resp.GetResources() { | ||
| for _, s := range r.GetDescription() { |
There was a problem hiding this comment.
If api just wants a list of resources, maybe the way core should store them is in just a list format.
for loops inside for loops scare me
anna-cross
force-pushed
the
ruby_list_resources
branch
from
bef0eda
to
59c1e85
Compare
dianadoherty
approved these changes
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Updating cli side of ruby list resources changes on turbine core. The structure of list resource response has changed, so we need to make appropriate changes to parse them in cli.
Fixes https://github.com/meroxa/turbine-core/issues/36
Type of change
How was this tested?