feat: make callback url configurable #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulb
force-pushed
the
raul/make-cli-login-configurable
branch
from
4f0e8f7
to
3ce1eb3
Compare
raulb
force-pushed
the
raul/make-cli-login-configurable
branch
from
3ce1eb3
to
e2102b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
In order to span up a new browser in a different environment (such as the one using Nimbus), we'll need to make callback urls configurable. This pull request should take care of that.
Type of change
How was this tested?
Demo
Before
Callback url is always "http://localhost:21900/oauth/callback"
Now
You can set different environment variables that would make it configurable:
MEROXA_AUTH_CALLBACK_HOSTMEROXA_AUTH_CALLBACK_URLMEROXA_AUTH_CALLBACK_PORTMEROXA_AUTH_CALLBACK_PROTOCOLMEROXA_AUTH_CALLBACK_URLwill take precedence over the rest in the event of that being set.Or simply do (for example):
MEROXA_AUTH_CALLBACK_URL=http://nimbus.meroxa.io/oauth/callback meroxa login