Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: apps and build commands are no longer beta #660

Merged
merged 5 commits into from
Mar 23, 2023

Conversation

janelletavares
Copy link
Contributor

@janelletavares janelletavares commented Mar 21, 2023

Description of change

Removing the beta tag

Fixes

Type of change

  • New feature
  • Bug fix
  • Refactor
  • Documentation

How was this tested?

  • Unit Tests
  • Tested in staging
  • Tested in minikube

Demo

before after

Additional references

Documentation updated

Copy link
Contributor

@jayjayjpg jayjayjpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads great so far, but I also noticed that this PR includes a couple of other changes with regards to environments work that seems to be unrelated to the removal of the beta tag -- would it be good to rebase the branch onto the latest master and pick out the beta changes?

Let me know if I'm missing something and happy to take another look!

Makefile Outdated Show resolved Hide resolved
cmd/meroxa/root/apps/deploy.go Outdated Show resolved Hide resolved
cmd/meroxa/root/apps/list_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@jayjayjpg jayjayjpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads great! Thank you for not only removing the beta tags, but also upgrading the linter in CI in one go! ✨

@raulb raulb changed the title Apps and build commands are no longer beta doc: apps and build commands are no longer beta Mar 22, 2023
@janelletavares janelletavares merged commit 6d8bea3 into master Mar 23, 2023
@janelletavares janelletavares deleted the no-longer-beta branch March 23, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants