Separate oauth scopes with URL-encoded space; fix default config name #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mentioned in https://meroxa.slack.com/archives/C01EV0UP210/p1614804137195500, the value of the `scope` param of the authorization URL is not separated by URL-encoded space. That causes the browser wasn't opened (https://github.com/meroxa/cli/blob/860ae625139927fe707f38112e02aa474baa185a/cmd/auth.go#L175). Replace the space with URL-encoded space `%20` opens the browser and I was able to authenticate successfully.
raulb
approved these changes
Mar 3, 2021
terrancej
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
As mentioned in https://meroxa.slack.com/archives/C01EV0UP210/p1614804137195500, the value of the
scopeparam of the authorization URL is not separated by URL-encoded space. The browser wasn't opened due to this bug:cli/cmd/auth.go
Line 175 in 860ae62
%20opens the browser and I was able to authenticate successfully.Type of change
How was this tested?
Additional references
https://meroxa.slack.com/archives/C01EV0UP210/p1614804137195500