Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: environment preflights table #740

Merged
merged 1 commit into from
May 18, 2023

Conversation

raulb
Copy link
Member

@raulb raulb commented May 17, 2023

Description of change

Fixes It also reuses the same function

Type of change

  • New feature
  • Bug fix
  • Refactor
  • Documentation

How was this tested?

  • Unit Tests
  • Tested in staging
  • Tested in minikube

Demo

Before

https://meroxa.slack.com/files/U01K6SFE06B/F058L7A0389/untitled

After

https://meroxa.slack.com/files/U01K6SFE06B/F05814EL18E/untitled

Additional references

This is mostly because my IAM role lacks tons of permissions.

@raulb raulb force-pushed the fix-preflight-check-when-lots-errors branch from a57abf9 to 5020bf4 Compare May 17, 2023 14:42
@raulb raulb added the bug Something isn't working label May 17, 2023
@raulb raulb self-assigned this May 17, 2023
@raulb raulb marked this pull request as ready for review May 17, 2023 14:44
@raulb raulb force-pushed the fix-preflight-check-when-lots-errors branch from 8c7689f to 5037c5d Compare May 17, 2023 14:45
@raulb raulb merged commit a1bcb52 into master May 18, 2023
@raulb raulb deleted the fix-preflight-check-when-lots-errors branch May 18, 2023 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants