Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for missing deployment #755

Merged
merged 1 commit into from
May 27, 2023
Merged

Check for missing deployment #755

merged 1 commit into from
May 27, 2023

Conversation

lyuboxa
Copy link
Contributor

@lyuboxa lyuboxa commented May 27, 2023

Description of change

Fixes an issue introduced by #753 where a missing deployment results in

> m apps deploy
Validating your app.json...
	✔ Checked your language is "golang"
	✔ Checked your application name is "filter-app"
Checking for uncommitted changes...
	✔ No uncommitted changes!
Error: could not find deployment

A missing deployment may be the result of an interrupted deployment due to build issues, if this does happen the app should be considered modified.

Type of change

  • New feature
  • Bug fix
  • Refactor
  • Documentation

How was this tested?

  • Unit Tests
  • Tested in staging
  • Tested in minikube

Demo

before after

Additional references

Documentation updated

@lyuboxa lyuboxa self-assigned this May 27, 2023
@lyuboxa lyuboxa merged commit f8ce9c9 into master May 27, 2023
@lyuboxa lyuboxa deleted the lk/missing-deployment branch May 27, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants