feat(flink): Remove enum association from Flink Job state field #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janelletavares
force-pushed
the
another-flink-state
branch
from
5c991a1
to
129bc24
Compare
janelletavares
changed the title
added 2 commits
June 2, 2023 11:00
samirketema
reviewed
Jun 2, 2023
go.mod
Outdated
| @@ -71,3 +71,5 @@ require ( | |||
| gopkg.in/ini.v1 v1.67.0 // indirect | |||
| gopkg.in/yaml.v3 v3.0.1 // indirect | |||
| ) | |||
|
|
|||
| replace github.com/meroxa/meroxa-go => ../meroxa-go | |||
There was a problem hiding this comment.
looks good, will wait for you to update meroxa-go and drop this before approving ✅
samirketema
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Fixes #761
Type of change
How was this tested?
Demo
Additional references
Documentation updated