Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for update of pipeline status #77

Merged
merged 1 commit into from
Mar 8, 2021
Merged

Conversation

dianadoherty
Copy link
Contributor

@dianadoherty dianadoherty commented Mar 4, 2021

Description of change

As part of work to pause/resume/restart pipelines, we want to be able to call the new API endpoint for updating the pipeline state

https://github.com/meroxa/platform-api/blob/fe4b68fcfaac0fa125f67fb6803ae4f182b075ba/cmd/api/router/router.go#L47

Fixes https://meroxa.atlassian.net/browse/PLATFORM-43

Screen Shot 2021-03-05 at 12 53 19 PM

Screen Shot 2021-03-05 at 12 57 31 PM

Type of change

  • New feature
  • Bug fix
  • Refactor
  • Documentation

How was this tested?

  • Unit Tests
  • Deployed to staging
  • Local testing

Additional references

Any additional links (if appropriate)

Documentation updated

Make sure that our documentation is accordingly updated when necessary.

Provide link:

@dianadoherty dianadoherty force-pushed the update-pipeline-status branch 2 times, most recently from 8482bb0 to 56b2204 Compare March 5, 2021 15:40
@dianadoherty dianadoherty self-assigned this Mar 5, 2021
@dianadoherty dianadoherty marked this pull request as ready for review March 5, 2021 17:58
@dianadoherty dianadoherty requested review from a team, owenthereal, terrancej, mwoods79 and raulb and removed request for a team March 5, 2021 17:58
Copy link
Contributor

@owenthereal owenthereal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after addressing the two feedback

cmd/update.go Outdated Show resolved Hide resolved
cmd/update.go Outdated Show resolved Hide resolved
@dianadoherty dianadoherty merged commit 45e0299 into master Mar 8, 2021
@dianadoherty dianadoherty deleted the update-pipeline-status branch March 8, 2021 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants