Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Endpoint command #78

Merged
merged 3 commits into from
Mar 5, 2021
Merged

Implement Endpoint command #78

merged 3 commits into from
Mar 5, 2021

Conversation

owenthereal
Copy link
Contributor

@owenthereal owenthereal commented Mar 5, 2021

Description of change

Implement Endpoint command. Client library is in https://github.com/meroxa/meroxa-go/pull/19. Server part is in https://github.com/meroxa/platform-api/pull/189.

$ meroxa create endpoint my-endpoint --protocol grpc --stream resource-2-499379-public.accounts
$ meroxa list endpoint
    NAME       PROTOCOL                STREAM                                                            URL                                               READY
============= ========== =================================== ============================================================================================ =======
       hello   GRPC       resource-2-499379-public.accounts   host=endpoint.test username=c10o5nrvevu3h1n6kkj0 password=X203gdSc7b94m1CM6FpNHLB8uyVKr5kU   True
 my-endpoint   GRPC       resource-2-499379-public.accounts   host=endpoint.test username=c10o763vevu3h1n6kkjg password=3WJx1BLR08AIqv7sQYUGyT9DzSr625M4   True
        owen   HTTP       resource-2-499379-public.accounts   https://c10jf5bvevu3h1n6kkig:ml163t7qvzETQfMWC4Lj28cF0k9agY5n@endpoint.test                  True
$ meroxa describe endpoint owen
 NAME   PROTOCOL                STREAM                                                     URL                                       READY
====== ========== =================================== ============================================================================= =======
 owen   HTTP       resource-2-499379-public.accounts   https://c10jf5bvevu3h1n6kkig:ml163t7qvzETQfMWC4Lj28cF0k9agY5n@endpoint.test   True
$ meroxa delete endpoint hello

Type of change

  • New feature
  • Bug fix
  • Refactor
  • Documentation

How was this tested?

  • Manual Test
  • Unit Tests
  • Deployed to staging

@owenthereal owenthereal requested review from ahmeroxa, lyuboxa, raulb, dianadoherty and mwoods79 and removed request for lyuboxa March 5, 2021 00:59
@raulb raulb merged commit 4772c41 into master Mar 5, 2021
@raulb raulb deleted the endpoint branch March 5, 2021 10:11
@raulb
Copy link
Member

raulb commented Mar 5, 2021

Something I forgot mentioning as part of this PR was to provide feedback to the user when things were happening (e.g.: "Creating endpoint... Endpoint created", etc...

I'll open a separate a PR as soon as I wrap up what I'm working on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants