Fix function always getting executed for turbine go #803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dianadoherty
force-pushed
the
fix-fn-always-executed
branch
from
9478e18
to
0a00b81
Compare
dianadoherty
requested review from
a team,
hariso and
ahmeroxa
and removed request for
a team
ericcheatham
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
For Turbine Go, functions are always getting executed, regardless of which meroxa apps command is run (
meroxa apps runandmeroxa apps deploy)We only want to execute the function during a
meroxa apps runFixes https://github.com/meroxa/turbine-go/issues/162
Depends on: https://github.com/meroxa/turbine-go/pull/175
Type of change
How was this tested?
Demo
Before
After