Generic functions to print tables and lists #830
Conversation
janelletavares
force-pushed
the
mdpx-display
branch
2 times, most recently
from
3c2aa18 to
d59094d
Compare
janelletavares
force-pushed
the
mdpx-display
branch
from
1aef869 to
c7f5d1a
Compare
utils/display/environments_test.go
Outdated
There was a problem hiding this comment.
Do we need environments files? We won't have actual env logic in mdpx right?
There was a problem hiding this comment.
i was under the impression that mdpx made environments easier and that we will continue to give customers to option to launch our platform in private environments. let's confirm.
There was a problem hiding this comment.
utils/display/display.go
Outdated
| } | ||
|
|
||
| // Keep the distinction between nil and empty slice input | ||
| if s.IsNil() { |
There was a problem hiding this comment.
I'm not sure you'd ever hit this case. If the parameter slice is nil the conditional if s.Kind() != reflect.Slice evaluates to true.
There was a problem hiding this comment.
i stole it from the StackExchange, so yeah this might need a little tweaking. thanks for looking!
There was a problem hiding this comment.
i made some changes and tested them with a hacked up unit test
Description of change
Fixes https://github.com/meroxa/mdpx/issues/575
Type of change
How was this tested?
Demo
Additional references
Documentation updated