Mdpx remove meroxa go #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulb
reviewed
Oct 27, 2023
There was a problem hiding this comment.
@anna-cross looks good. Aside from some linting issues, it should be ready to ship.
cmd/meroxa/global/global.go
Outdated
| TenantSubdomainEnv = "TENANT_SUBDOMAIN" | ||
| TenantEmailAddress = "TENANT_EMAIL_ADDRESS" | ||
| TenantPassword = "TENANT_PASSWORD" | ||
| Actor = "ACTOR" |
There was a problem hiding this comment.
Nope! Good catch, this can go!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Removing dependencies on meroxa-go. There were a lot of unneeded old functions and processes that use meroxa-go that are no longer needed for mdpx.
I've removed a lot of flink code but kept the files as stubs since we will still be implementing flink down the line
Fixes https://github.com/meroxa/mdpx/issues/630
Type of change
How was this tested?