Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add secrets command to CLI #847

Merged
merged 5 commits into from
Nov 2, 2023
Merged

Add secrets command to CLI #847

merged 5 commits into from
Nov 2, 2023

Conversation

anna-cross
Copy link
Contributor

@anna-cross anna-cross commented Nov 1, 2023

Description of change

We want to be able to add, list, describe , remove and update secrets from CLI.

Fixes https://github.com/meroxa/mdpx/issues/656

Type of change

  • New feature
  • Bug fix
  • Refactor
  • Documentation

How was this tested?

  • Unit Tests
  • Tested in staging
  • Tested in minikube

Demo

(In slack)

Copy link
Contributor

@nassor nassor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice little refactorings as well :)

Copy link
Contributor

@samirketema samirketema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one comment about commented code we can remove

Comment on lines 79 to 80
// fmt.Printf("Field: %s\n", o)
// fmt.Printf("Value: %v\n", amorphous[o])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps leftover from debugging?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup! removing it!

@anna-cross anna-cross merged commit f45fcdb into mdpx Nov 2, 2023
4 checks passed
@anna-cross anna-cross deleted the mdpx_secrets branch November 2, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants