Mdpx Conduit Application Changes #878
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nassor
reviewed
Apr 2, 2024
cmd/meroxa/root/apps/apps.go
Outdated
Comment on lines
46
to
47
| deploymentCollection = "conduitdeployments" | ||
| applicationCollection = "conduitapps" |
There was a problem hiding this comment.
There was a problem hiding this comment.
you can wait til having the full deployment functionality in the repo.
nassor
reviewed
Apr 2, 2024
cmd/meroxa/root/apps/describe.go
Outdated
| @@ -103,7 +79,7 @@ func (d *Describe) Execute(ctx context.Context) error { | |||
| for _, app := range apps.Items { | |||
| d.logger.Info(ctx, display.PrintTable(app, displayDetails)) | |||
| d.logger.JSON(ctx, app) | |||
| dashboardURL := fmt.Sprintf("%s/apps/%s/detail", global.GetMeroxaAPIURL(), app.ID) | |||
| dashboardURL := fmt.Sprintf("%s/conduitapps/%s/detail", global.GetMeroxaAPIURL(), app.ID) | |||
There was a problem hiding this comment.
nassor
reviewed
Apr 2, 2024
cmd/meroxa/root/apps/list.go
Outdated
| @@ -71,7 +71,7 @@ func (l *List) Execute(ctx context.Context) error { | |||
| l.logger.Info(ctx, display.PrintList(apps.Items, displayDetails)) | |||
| l.logger.JSON(ctx, apps) | |||
|
|
|||
| output := fmt.Sprintf("\n ✨ To view your applications, visit %s/apps", global.GetMeroxaAPIURL()) | |||
| output := fmt.Sprintf("\n ✨ To view your applications, visit %s/conduitapps", global.GetMeroxaAPIURL()) | |||
There was a problem hiding this comment.
nassor
reviewed
Apr 2, 2024
| @@ -0,0 +1,214 @@ | |||
| package apps | |||
There was a problem hiding this comment.
There is no:
app.json(one day, we will probably haveapp.yaml)- the need for using git.
There was a problem hiding this comment.
I'm removing this for now until we will add app.yaml support!
anna-cross
force-pushed
the
mdpx_conduitapp
branch
from
69e783f
to
66a03fb
Compare
lyuboxa
reviewed
Apr 26, 2024
cmd/meroxa/root/apps/apps.go
Outdated
| DeploymentID []string `json:"deployment_id"` | ||
| Name string `json:"name"` | ||
| State string `json:"state"` | ||
| ApplicationSpec string `json:"stream_tech"` |
There was a problem hiding this comment.
this was renamed to stream_provider not sure where stream_tech is coming from?
|
@anna-cross can you make another PR which removes all the turbine stuff, then rebase this PR from the other pr, so we can easily review the new code. |
anna-cross
force-pushed
the
mdpx_conduitapp
branch
from
7b73939
to
6e93a2d
Compare
nassor
reviewed
May 15, 2024
| "items": [ | ||
| { | ||
| "collectionId": "77byam8idl1rv8b", | ||
| "collectionName": "conduitapps", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Changes for conduit application, removing turbine references and usage. Includes new user login as well, we don't need to set env variables, the cli will just prompt the user for inputs.
How to test / use:
meroxa app deploy . --timeout 90sto deploy the appmeroxa app lsmeroxa app remove test-pipeline-2 --forcewith test-pipeline-2 coming from conduit app nameFixes https://github.com/meroxa/mdpx/issues/1674
Type of change
How was this tested?
Demo
Additional references
Documentation updated