Skip to content

Conversation

updates:
- [github.com/astral-sh/ruff-pre-commit: v0.4.3 → v0.5.6](astral-sh/ruff-pre-commit@v0.4.3...v0.5.6)
- [github.com/asottile/pyupgrade: v3.15.2 → v3.17.0](asottile/pyupgrade@v3.15.2...v3.17.0)
- [github.com/codespell-project/codespell: v2.2.6 → v2.3.0](codespell-project/codespell@v2.2.6...v2.3.0)
@codecov
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files Patch % Lines
mesa_frames/concrete/model.py 0.00% 1 Missing ⚠️
Files Coverage Δ
mesa_frames/concrete/model.py 71.42% <0.00%> (ø)

@EwoutH
Copy link
Member

EwoutH commented Aug 6, 2024

One thing pre-commit can't / doesn't automatically fix:

mesa_frames/concrete/model.py:98:16: E721 Use `is` and `is not` for type comparisons, or `isinstance()` for isinstance checks
    |
 96 |         """
 97 |         for agentset in self._agents._agentsets:
 98 |             if agent_type == type(agentset):
    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ E721
 99 |                 return agentset
100 |         raise ValueError(f"No agents of type {agent_type} found in the model.")
    |

Found 1 error.

@adamamer20
Copy link
Member

thanks @EwoutH. i'll fix that

@adamamer20 adamamer20 merged commit 35b0edf into main Aug 12, 2024
@adamamer20 adamamer20 deleted the pre-commit-ci-update-config branch August 12, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants