Add back extension codes for Uint8Array and Int32Array #172
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were accidentally lost in the switch to msgpack-javascript (#132).
Closes #138.
+@SeanCurtis-TRI for both reviews, please.
It's not really practical to test this with an HTML file in this repository. The problem is with the msgpack decoding, which we usually don't test here (we author JSON in tests, not msgpack).
Instead, I tested it manually with this Python program that uses
meshcat-python:With the master branch meshcat, it errors out with no cube (the browser console has an error message). With this branch, the browser shows the cube.
I didn't test the int32 decoder. (I can't find anywhere its used.) Hopefully the visual inspection and copy-paste from Uint32 is sufficient.
This change is