custom platform implementation #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malhussan
reviewed
Jul 25, 2024
There was a problem hiding this comment.
Thanks @gregorzavodnik!
One thing to note, is that for a custom platform, at least as a V1, I recommend not adding any CLI setup.
| return { | ||
| id, | ||
| name, | ||
| custom: "type", |
There was a problem hiding this comment.
should be the other way around (type: "custom")
src/model/PlatformConfig.ts
Outdated
Comment on lines
46
to
47
| aadTenantId: string; | ||
| subscriptionId: string; |
There was a problem hiding this comment.
aadTenantId and subscriptionId are Azure references, and should be adapted
src/model/schemas/schema.json
Outdated
| "collie": { | ||
| "$ref": "#/definitions/CollieConfig" | ||
| }, | ||
| "azure": {} |
There was a problem hiding this comment.
"azure" does not belong under custom
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to select a custom platform when creating a new foundation