remove collie kit compile command and add opentofu support #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We figured out this use case is better served by tools like pre-commit-terraform https://github.com/antonbabenko/pre-commit-terraform?tab=readme-ov-file#terraform_validate which includes more robust handling of terraform's quirks. Given that there are better solutions out there, we think it's best to remove this feature from collie and focus our resources on unique features. Additionally, using "terraform validate" is a bad fit for validating kit modules as it has big problems with configuration_aliases hashicorp/terraform#28490 It seems that it is much better suited to validating platform modules instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We figured out this use case is better served by tools like pre-commit-terraform
https://github.com/antonbabenko/pre-commit-terraform?tab=readme-ov-file#terraform_validate
which includes more robust handling of terraform's quirks. Given that
there are better solutions out there, we think it's best to remove this
feature from collie and focus our resources on unique features.
Additionally, using "terraform validate" is a bad fit for validating
kit modules as it has big problems with configuration_aliases
hashicorp/terraform#28490
It seems that it is much better suited to validating platform modules instead.