Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add helm plugin to generate snapshot #25

Merged
merged 21 commits into from
Sep 30, 2024

Conversation

Aijeyomah
Copy link
Contributor

@Aijeyomah Aijeyomah commented Sep 26, 2024

Description

This PR fixes #11431

Notes for Reviewers

  • Add Helm plugin to generate Kanvas snaphot from helm chart
Screenshot 2024-09-26 at 14 13 37

Signed commits

  • Yes, I signed my commits.

Copy link

welcome bot commented Sep 26, 2024

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, you can find updates in the #github-notifications channel in the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while performing a commit.

@github-actions github-actions bot added the area/ci Continuous integration | Build and release label Sep 26, 2024
@Aijeyomah
Copy link
Contributor Author

@MUzairS15 When I used the meshkit error, It didn't log in the terminal. How can I fix that?

@Aijeyomah Aijeyomah marked this pull request as ready for review September 26, 2024 13:04
@Aijeyomah
Copy link
Contributor Author

@leecalcote

  1. I ran into a blocker where meshkit couldn't log errors to the terminal, which cost me quite some time. To get around that, I switched to using the log package for now. I’ll revert back to meshkit logging once I figure out the issue.

  2. I created a Makefile for testing locally. I didn’t add any credentials to the environment since those are tied to my personal ones.

  3. The Git polling didn’t work as expected. When the workflow is dispatched, GitHub returns a 204 response, which doesn’t provide any useful data. To poll GitHub and track the workflow run, we would need the run ID, which we don’t get. To handle this, I implemented a loader that runs for 2 minutes and 40 seconds (the average time it takes for the workflow to complete) before returning the snapshot to the terminal.

@leecalcote
Copy link
Member

Regarding 1. It sounds like this isn’t an issue anymore good. Only MeshKit should be used for both logging and errors. Make sure that each period errors have a short description, long description, probable cause, and suggested remediation.

@leecalcote
Copy link
Member

Regarding 2. This should be fixed shortly as we merge and tidy up workflows.

@leecalcote
Copy link
Member

Regarding three. Don’t do this. That’s not Paul get up for status. I’m not convinced that we should be supporting a non-email based flow.

Our time spent on trying to figure out how to let people know when the snapshot will be ready is time wasted when they can simply provide an email.

@leecalcote
Copy link
Member

@Aijeyomah please fix the eslint configuration in this repo/build workflow

@MUzairS15
Copy link

@Aijeyomah I have pushed commits, please sync your cloud PR and test it.

@pontusringblom
Copy link
Contributor

@Aijeyomah, how can I try this command?

.goreleaser.yaml Outdated Show resolved Hide resolved
.goreleaser.yaml Outdated Show resolved Hide resolved
.goreleaser.yaml Outdated Show resolved Hide resolved
@Aijeyomah Aijeyomah force-pushed the helm-snapshot-plugin branch 2 times, most recently from 067af6c to 794d696 Compare September 28, 2024 01:09
Signed-off-by: Eti Ijeoma <ijayeti@gmail.com>
Signed-off-by: Eti Ijeoma <ijayeti@gmail.com>
Signed-off-by: Eti Ijeoma <ijayeti@gmail.com>
Signed-off-by: Eti Ijeoma <ijayeti@gmail.com>
Signed-off-by: Eti Ijeoma <ijayeti@gmail.com>
Signed-off-by: Eti Ijeoma <ijayeti@gmail.com>
Signed-off-by: Eti Ijeoma <ijayeti@gmail.com>
Signed-off-by: Eti Ijeoma <ijayeti@gmail.com>
Signed-off-by: Eti Ijeoma <ijayeti@gmail.com>
Signed-off-by: Eti Ijeoma <ijayeti@gmail.com>
Signed-off-by: Eti Ijeoma <ijayeti@gmail.com>
Signed-off-by: Eti Ijeoma <ijayeti@gmail.com>
Signed-off-by: Eti Ijeoma <ijayeti@gmail.com>
Signed-off-by: Eti Ijeoma <ijayeti@gmail.com>
Signed-off-by: Eti Ijeoma <ijayeti@gmail.com>
Signed-off-by: Eti Ijeoma <ijayeti@gmail.com>
jobs:
release:
if: github.repository == 'helm-kanvas-snapshot' && startsWith(github.ref, 'refs/tags/v') && !contains(github.ref, 'patch') && !contains(github.ref, 'alpha') && !contains(github.ref, 'beta') && !contains(github.ref, 'rc')
runs-on: macos-latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason that we're using macos? I wonder how many build minutes are offered on this OS.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use of macos uses 10x more minutes than a linux OS. I'm not sure if there is any limit to our build minute limit in public repo, though, so this might not matter. I'm not sure.

Co-authored-by: pontusringblom <170570911+pontusringblom@users.noreply.github.com>
Signed-off-by: Lee Calcote <leecalcote@gmail.com>
README.md Outdated
### Prerequisites

- Helm v3 or later must be installed on your system.
- Go
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Go

Golang insn't necessary for installation, only for building, right?

Signed-off-by: Lee Calcote <lee.calcote@layer5.io>
Signed-off-by: Lee Calcote <lee.calcote@layer5.io>
Signed-off-by: Lee Calcote <lee.calcote@layer5.io>
@leecalcote leecalcote merged commit 1fbfbae into meshery:master Sep 30, 2024
14 of 25 checks passed
Copy link

welcome bot commented Sep 30, 2024

Thanks for your contribution to Meshery! 🎉

Meshery Logo
        Join the community, if you haven't yet and please leave a ⭐ star on the project. 😄

@MUzairS15
Copy link

@Aijeyomah I see the Terminal logger from meshkit is being redefined. Any specific reason? I pushed commits to organize the code, did those got lost while resolving the conflicts?

@leecalcote
Copy link
Member

@Aijeyomah is this still in process of being resolved or has this been addressed?

@Aijeyomah
Copy link
Contributor Author

@Aijeyomah I see the Terminal logger from meshkit is being redefined. Any specific reason? I pushed commits to organize the code, did those got lost while resolving the conflicts?

The logger file was empty when I pulled the changes from master, so I added those there. Maybe it occurred while fixing conflicts

@Aijeyomah
Copy link
Contributor Author

@Aijeyomah is this still in process of being resolved or has this been addressed?

It's in the process

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Continuous integration | Build and release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants