-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add helm plugin to generate snapshot #25
Conversation
Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, you can find updates in the #github-notifications channel in the community Slack. |
@MUzairS15 When I used the meshkit error, It didn't log in the terminal. How can I fix that? |
|
Regarding 1. It sounds like this isn’t an issue anymore good. Only MeshKit should be used for both logging and errors. Make sure that each period errors have a short description, long description, probable cause, and suggested remediation. |
Regarding 2. This should be fixed shortly as we merge and tidy up workflows. |
Regarding three. Don’t do this. That’s not Paul get up for status. I’m not convinced that we should be supporting a non-email based flow. Our time spent on trying to figure out how to let people know when the snapshot will be ready is time wasted when they can simply provide an email. |
@Aijeyomah please fix the eslint configuration in this repo/build workflow |
2847786
to
00ed898
Compare
@Aijeyomah I have pushed commits, please sync your cloud PR and test it. |
@Aijeyomah, how can I try this command? |
067af6c
to
794d696
Compare
Signed-off-by: Eti Ijeoma <ijayeti@gmail.com>
Signed-off-by: Eti Ijeoma <ijayeti@gmail.com>
Signed-off-by: Eti Ijeoma <ijayeti@gmail.com>
Signed-off-by: Eti Ijeoma <ijayeti@gmail.com>
Signed-off-by: Eti Ijeoma <ijayeti@gmail.com>
Signed-off-by: Eti Ijeoma <ijayeti@gmail.com>
Signed-off-by: Eti Ijeoma <ijayeti@gmail.com>
Signed-off-by: Eti Ijeoma <ijayeti@gmail.com>
Signed-off-by: Eti Ijeoma <ijayeti@gmail.com>
Signed-off-by: Eti Ijeoma <ijayeti@gmail.com>
Signed-off-by: Eti Ijeoma <ijayeti@gmail.com>
Signed-off-by: Eti Ijeoma <ijayeti@gmail.com>
Signed-off-by: Eti Ijeoma <ijayeti@gmail.com>
Signed-off-by: Eti Ijeoma <ijayeti@gmail.com>
Signed-off-by: Eti Ijeoma <ijayeti@gmail.com>
abe8674
to
0da7f9e
Compare
Signed-off-by: Eti Ijeoma <ijayeti@gmail.com>
jobs: | ||
release: | ||
if: github.repository == 'helm-kanvas-snapshot' && startsWith(github.ref, 'refs/tags/v') && !contains(github.ref, 'patch') && !contains(github.ref, 'alpha') && !contains(github.ref, 'beta') && !contains(github.ref, 'rc') | ||
runs-on: macos-latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason that we're using macos? I wonder how many build minutes are offered on this OS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use of macos uses 10x more minutes than a linux OS. I'm not sure if there is any limit to our build minute limit in public repo, though, so this might not matter. I'm not sure.
Co-authored-by: pontusringblom <170570911+pontusringblom@users.noreply.github.com> Signed-off-by: Lee Calcote <leecalcote@gmail.com>
README.md
Outdated
### Prerequisites | ||
|
||
- Helm v3 or later must be installed on your system. | ||
- Go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Go |
Golang insn't necessary for installation, only for building, right?
Signed-off-by: Lee Calcote <lee.calcote@layer5.io>
Signed-off-by: Lee Calcote <lee.calcote@layer5.io>
Signed-off-by: Lee Calcote <lee.calcote@layer5.io>
Thanks for your contribution to Meshery! 🎉
|
@Aijeyomah I see the Terminal logger from meshkit is being redefined. Any specific reason? I pushed commits to organize the code, did those got lost while resolving the conflicts? |
@Aijeyomah is this still in process of being resolved or has this been addressed? |
The logger file was empty when I pulled the changes from master, so I added those there. Maybe it occurred while fixing conflicts |
It's in the process |
Description
This PR fixes #11431
Notes for Reviewers
Signed commits