[CI] partial release and install fixes #46
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lee Calcote <lee.calcote@layer5.io>
hexxdump
reviewed
Oct 21, 2024
|
|
||
| # Handle HELM_PLUGIN_DIR filepath based on OS. Use *nix-based filepathing | ||
|
|
||
| if type cygpath >/dev/null 2>&1; then |
There was a problem hiding this comment.
For platforms other than windows, the HELM_PLUGIN_DIR is going to be "" and eventually the CWD is used for downloading the files, right?
| else | ||
| # Use the GitHub API to find the download url for this project. | ||
| url="https://api.github.com/repos/$PROJECT_GH/releases/latest" | ||
| if type "curl" >/dev/null; then |
There was a problem hiding this comment.
verfiySupported checks for curl and wget already, do we need these checks again ?
There was a problem hiding this comment.
Probably not. Please change at-will
|
Addressed in #51 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lee Calcote lee.calcote@layer5.io
Notes for Reviewers
This PR partially addresses the need for an
installandupdatescript (could be the same script). I'm guessing thathelmtakes care ofuninstallinsomuch as is needed for this plugin, which would be to delete the cloned repo (this repo) from user's filesystem.Please feel free to checkout this branch and add commits or to close this PR and start your own.
Resources:
Signed commits