Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Fix failing lint #57

Merged
merged 2 commits into from
Nov 10, 2024

Conversation

theBeginner86
Copy link
Member

Notes for Reviewers

This PR fixes the failing lint checks on master https://github.com/meshery/helm-kanvas-snapshot/actions/runs/11711274987/job/32619423480

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Copy link

welcome bot commented Nov 10, 2024

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, you can find updates in the #github-notifications channel in the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while performing a commit.

Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@leecalcote leecalcote merged commit 3018730 into meshery:master Nov 10, 2024
8 checks passed
Copy link

welcome bot commented Nov 10, 2024

Thanks for your contribution to Meshery! 🎉

Meshery Logo
        Join the community, if you haven't yet and please leave a ⭐ star on the project. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants