New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Fix Install Script #65

Merged

theBeginner86 merged 3 commits into meshery:master from theBeginner86:thebeginner86/chore/2

Nov 23, 2024

Member

theBeginner86 commented Nov 23, 2024 •

edited

Loading

Notes for Reviewers

Fixes the install script by standardizing functions, use of variables, adds missing OS/Arch detection function
Bumps version in plugin.yaml
Adds missing support to update plugin

This PR fixes #63

Screenshot 2024-11-23 at 3 53 13 PM

Signed commits

Yes, I signed my commits.

theBeginner86 added 3 commits

November 23, 2024 15:39


          fix plugin version

9b2ccc7

Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>


          fix install script

7b229ce

Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>


          fix logs; add update support

331a41a

Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>

theBeginner86 merged commit 206136e into meshery:master

2 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet