Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Fix request headers #71

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

theBeginner86
Copy link
Member

@theBeginner86 theBeginner86 commented Nov 30, 2024

Notes for Reviewers

This PR fixes the request headers for requesting MesheryAPI and MesheryCloudAPI by setting the missing provider-token and provider key in cookies

Screenshot 2024-11-30 at 3 39 01 PM

This PR fixes #

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
@theBeginner86
Copy link
Member Author

After merging this PR we still need to fix the endpoint for triggering the workflow. Currently its seems bogus as its returning 404.
I don't remember the endpoint so if any of maintainer can please update the endpoint then we should be good 👍

Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
@github-actions github-actions bot added the area/ci Continuous integration | Build and release label Dec 15, 2024
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
@theBeginner86
Copy link
Member Author

Updates:

  1. Added support to trigger snapshot workflow in meshery/helm-kanvas-snapshot
  2. Added missing kanvas snapshot workflow
  3. Removed required email field

This is how it would work:
Screenshot 2024-12-15 at 4 43 26 PM

@theBeginner86
Copy link
Member Author

theBeginner86 commented Dec 15, 2024

@leecalcote @jerensl

Though the snapshot service itself is failing for past 2 days, once its fixed then we should be good.
https://github.com/meshery/meshery/actions/workflows/kanvas.yml
https://github.com/meshery/meshery.io/actions/workflows/kanvas.yml

@theBeginner86
Copy link
Member Author

theBeginner86 commented Dec 15, 2024

Can someone with privileges add the missing GitHub access token that can trigger workflow? It would fix the failing check. Then we can merge and release. https://github.com/meshery/helm-kanvas-snapshot/actions/runs/12338342779/job/34433184955?pr=71

Fixed ✅

@jerensl
Copy link

jerensl commented Dec 15, 2024

Can someone with privileges add the missing GitHub access token that can trigger workflow? It would fix the failing check. Then we can merge and release

https://github.com/meshery/helm-kanvas-snapshot/actions/runs/12338342779/job/34433184955?pr=71

GH_ACCESS_TOKEN is already being set as repository secret

Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
Signed-off-by: Pranav Singh <pranavsingh02@hotmail.com>
@Aijeyomah
Copy link
Contributor

@theBeginner86 Is this a temporary fix for the unmerged PR in the meshery cloud that already handles triggering of the workflow?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Continuous integration | Build and release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants