Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] upgrade meshkit and adapter library #134

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

nebula-aac
Copy link
Contributor

Description

This PR fixes the error received in the Kubernetes deployment. This PR is to update meshkit and meshery-adapter-library to the latest.

panic: interface conversion: error is *fs.PathError, not *errors.Error

goroutine 14 [running]:
github.com/layer5io/meshkit/errors.GetCode({0x278e020?, 0xc0004402a0?})
        /go/pkg/mod/github.com/layer5io/meshkit@v0.6.31/errors/errors.go:105 +0x90
github.com/layer5io/meshkit/logger.(*Logger).Error(0xc0000120f8, {0x278e020, 0xc0004402a0})
        /go/pkg/mod/github.com/layer5io/meshkit@v0.6.31/logger/logger.go:75 +0xbe
main.registerWorkloads({0x2403170, 0x5}, {0x27b2780, 0xc0000120f8})
        /github.com/meshery/meshery-cilium/main.go:223 +0x7f6
main.registerDynamicCapabilities({0x2403170, 0x5}, {0x27b2780, 0xc0000120f8})
        /github.com/meshery/meshery-cilium/main.go:166 +0x2d
created by main.main
        /github.com/meshery/meshery-cilium/main.go:113 +0x6d5

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Antonette Caldwell <acald.nebula@gmail.com>
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yessss

@leecalcote
Copy link
Member

Merge and Release at-will. A couple of e2e tests are finishing up.

@nebula-aac nebula-aac merged commit 3c8b987 into meshery:master Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants