-
Notifications
You must be signed in to change notification settings - Fork 106
fix: golangcli-lint to run #696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
032790a to
b2558d0
Compare
n2h9
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello 👋
lint step is failing in CI (refer to the output of GitHub action job run output).
b2558d0 to
b98a82e
Compare
|
ouch, nothing comes up here, i have tested locally and it was working cause i had global config file for it, i have updated the config to the new schema, lmk if these are the same rules(it might be a little stricter) cause of the static analyzer. but this introduced a whole new issue(ref code to match the rules of the lintters or change lintters settings to match the codebase) |
|
i think the merging from the old schema to the new schema(by golangci-lint ) is working now the only issue is the codebase formatter and linters |
n2h9
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello 👋
The lint step is failing in CI;
there are conflicts in .golangci.yml needs to be addressed. I think it were recently couple prs merged which were trying to address linter issues.
b98a82e to
c8e8019
Compare
i have rebassed to the master, and most of the new prs, fails on linting stage |
n2h9
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello 👋
The lint step is failing in CI; there are conflicts in.golangci.ymlneeds to be addressed. I think it were recently couple prs merged which were trying to address linter issues.i have rebassed to the master, and most of the new prs, fails on linting stage
Ok, if this pr does not fix golangci-lint run in github actions, what do we want to merge here?
- removed the extra fields - removed deprecated linters - used new schmea Signed-off-by: Amr-Shams <amr.shams2015.as@gmail.com>
c8e8019 to
8877cad
Compare
oops, thanx for your time, my merge conflict wasn't correct. a |
Description
removed the extra fields
This PR fixes #
this pr fixes the golangci-lint config file by removing the extra fields
Signed commits