Skip to content

Conversation

@Amr-Shams
Copy link
Contributor

Description
removed the extra fields
This PR fixes #

this pr fixes the golangci-lint config file by removing the extra fields

Signed commits

  • Yes, I signed my commits.

@Amr-Shams Amr-Shams force-pushed the fix/golangcli-lint branch 2 times, most recently from 032790a to b2558d0 Compare January 2, 2026 09:47
Copy link
Contributor

@n2h9 n2h9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello 👋

lint step is failing in CI (refer to the output of GitHub action job run output).

@Amr-Shams
Copy link
Contributor Author

ouch, nothing comes up here, i have tested locally and it was working cause i had global config file for it, i have updated the config to the new schema, lmk if these are the same rules(it might be a little stricter) cause of the static analyzer. but this introduced a whole new issue(ref code to match the rules of the lintters or change lintters settings to match the codebase)

@Amr-Shams
Copy link
Contributor Author

i think the merging from the old schema to the new schema(by golangci-lint ) is working now the only issue is the codebase formatter and linters
@n2h9

@Amr-Shams Amr-Shams requested a review from n2h9 January 10, 2026 10:11
Copy link
Contributor

@n2h9 n2h9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello 👋

The lint step is failing in CI;
there are conflicts in .golangci.yml needs to be addressed. I think it were recently couple prs merged which were trying to address linter issues.

@Amr-Shams Amr-Shams requested a review from n2h9 January 10, 2026 10:36
@Amr-Shams
Copy link
Contributor Author

Hello 👋

The lint step is failing in CI; there are conflicts in .golangci.yml needs to be addressed. I think it were recently couple prs merged which were trying to address linter issues.

i have rebassed to the master, and most of the new prs, fails on linting stage

Copy link
Contributor

@n2h9 n2h9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello 👋
The lint step is failing in CI; there are conflicts in .golangci.yml needs to be addressed. I think it were recently couple prs merged which were trying to address linter issues.

i have rebassed to the master, and most of the new prs, fails on linting stage

Ok, if this pr does not fix golangci-lint run in github actions, what do we want to merge here?

- removed the extra fields
- removed deprecated linters
- used new schmea

Signed-off-by: Amr-Shams <amr.shams2015.as@gmail.com>
@Amr-Shams Amr-Shams requested a review from n2h9 January 10, 2026 10:59
@Amr-Shams
Copy link
Contributor Author

Hello 👋
The lint step is failing in CI; there are conflicts in .golangci.yml needs to be addressed. I think it were recently couple prs merged which were trying to address linter issues.

i have rebassed to the master, and most of the new prs, fails on linting stage

Ok, if this pr does not fix golangci-lint run in github actions, what do we want to merge here?

oops, thanx for your time, my merge conflict wasn't correct. a
i have checked again the lint, and used the verfiy command and test it using make lint to check it is working, (but now many issues popup on the code base)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants