Skip to content
This repository has been archived by the owner on Sep 27, 2023. It is now read-only.

chore: update go version and workflow files #265

Closed
wants to merge 1 commit into from

Conversation

ptdatta
Copy link

@ptdatta ptdatta commented Sep 15, 2023

Description
Updated go version

This PR fixes #264

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Parthib <parthibdutta02@gmail.com>
@welcome
Copy link

welcome bot commented Sep 15, 2023

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Contributors' Welcome Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

@ptdatta
Copy link
Author

ptdatta commented Sep 15, 2023

@leecalcote @theBeginner86 @saurabh100ni does I need to change actions/setup-go@master to actions/setup-go@v4. Or it automatically take the latest version??

@leecalcote
Copy link
Member

Running build checks...

@nebula-aac
Copy link

nebula-aac commented Sep 16, 2023

After testing this PR,

The top portion of the go.mod needs to be this

module github.com/layer5io/meshery-osm

go 1.21

replace github.com/kudobuilder/kuttl => github.com/layer5io/kuttl v0.4.1-0.20200723152044-916f10574334

require (
	github.com/google/uuid v1.3.1
	github.com/layer5io/meshery-adapter-library v0.6.9
	github.com/layer5io/meshkit v0.6.65
	github.com/layer5io/service-mesh-performance v0.6.1
	gopkg.in/yaml.v2 v2.4.0
	k8s.io/apimachinery v0.28.2
)

but after doing this, there is indirect dep that creeped in from meshkit@v0.6.65 but this wasn't a problem in meshery-kuma: meshery/meshery-kuma#416

# oras.land/oras-go/pkg/auth/docker
/go/pkg/mod/oras.land/oras-go@v1.2.3/pkg/auth/docker/login.go:86:39: cannot use remote (variable of type *"github.com/docker/docker/registry".Service) as "github.com/docker/docker/registry".Service value in argument to c.loginWithTLS

@ptdatta
Copy link
Author

ptdatta commented Sep 16, 2023

After testing this PR,

The top portion of the go.mod needs to be this

module github.com/layer5io/meshery-osm

go 1.21

replace github.com/kudobuilder/kuttl => github.com/layer5io/kuttl v0.4.1-0.20200723152044-916f10574334

require (
	github.com/google/uuid v1.3.1
	github.com/layer5io/meshery-adapter-library v0.6.9
	github.com/layer5io/meshkit v0.6.65
	github.com/layer5io/service-mesh-performance v0.6.1
	gopkg.in/yaml.v2 v2.4.0
	k8s.io/apimachinery v0.28.2
)

but after doing this, there is indirect dep that creeped in from meshkit@v0.6.65 but this wasn't a problem in meshery-kuma: meshery/meshery-kuma#416

# oras.land/oras-go/pkg/auth/docker
/go/pkg/mod/oras.land/oras-go@v1.2.3/pkg/auth/docker/login.go:86:39: cannot use remote (variable of type *"github.com/docker/docker/registry".Service) as "github.com/docker/docker/registry".Service value in argument to c.loginWithTLS

@nebula-aac Did I need to add it on top of the go.mod file?

@nebula-aac
Copy link

Actually, we need to cancel this PR, as this repo is supposed to be archived.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[chore] update Go to 1.21, and update relevant pkgs
3 participants